From a60171ca78b4b601b72274f2132816ea247ca55d Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Sat, 17 May 2008 18:59:07 +0000 Subject: Bug 434062: Attachment flags can only be set once per bug (regression) - Patch by Frédéric Buclin a=LpSolit (module owner) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Flag.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'Bugzilla/Flag.pm') diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index a65a8268b..6266b0c0c 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -228,12 +228,12 @@ sub match { # If the caller specified only bug or attachment flags, # limit the query to those kinds of flags. if (my $type = delete $criteria->{'target_type'}) { - if ($type eq 'attachment') { - $criteria->{'attach_id'} = NOT_NULL; - } - else { + if ($type eq 'bug') { $criteria->{'attach_id'} = IS_NULL; } + elsif (!defined $criteria->{'attach_id'}) { + $criteria->{'attach_id'} = NOT_NULL; + } } # Flag->snapshot() calls Flag->match() with bug_id and attach_id # as hash keys, even if attach_id is undefined. -- cgit v1.2.3-24-g4f1b