From 6377a5d742fa2a04be4f2452142535602d9e7620 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Thu, 6 Jul 2006 04:45:15 +0000 Subject: Bug 232705: FlagType::normalize() not used; remove it - Patch by Frédéric Buclin r/a=myk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/FlagType.pm | 49 ------------------------------------------------- 1 file changed, 49 deletions(-) (limited to 'Bugzilla/FlagType.pm') diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index ce4f31e68..e31e2337c 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -428,55 +428,6 @@ sub validate { } } -=pod - -=over - -=item C - -Given a list of flag types, checks its flags to make sure they should -still exist after a change to the inclusions/exclusions lists. - -=back - -=cut - -sub normalize { - # A list of IDs of flag types to normalize. - my (@ids) = @_; - my $dbh = Bugzilla->dbh; - - my $ids = join(", ", @ids); - - # Check for flags whose product/component is no longer included. - my $flag_ids = $dbh->selectcol_arrayref(" - SELECT flags.id - FROM (flags INNER JOIN bugs ON flags.bug_id = bugs.bug_id) - LEFT OUTER JOIN flaginclusions AS i - ON (flags.type_id = i.type_id - AND (bugs.product_id = i.product_id OR i.product_id IS NULL) - AND (bugs.component_id = i.component_id OR i.component_id IS NULL)) - WHERE flags.type_id IN ($ids) - AND i.type_id IS NULL"); - - foreach my $flag_id (@$flag_ids) { - Bugzilla::Flag::clear($flag_id); - } - - $flag_ids = $dbh->selectcol_arrayref(" - SELECT flags.id - FROM flags, bugs, flagexclusions AS e - WHERE flags.type_id IN ($ids) - AND flags.bug_id = bugs.bug_id - AND flags.type_id = e.type_id - AND (bugs.product_id = e.product_id OR e.product_id IS NULL) - AND (bugs.component_id = e.component_id OR e.component_id IS NULL)"); - - foreach my $flag_id (@$flag_ids) { - Bugzilla::Flag::clear($flag_id); - } -} - ###################################################################### # Private Functions ###################################################################### -- cgit v1.2.3-24-g4f1b