From 8832bf88d9c7720750dc5ae1f75f50e1b6e8c89c Mon Sep 17 00:00:00 2001 From: "jouni%heikniemi.net" <> Date: Tue, 20 Jul 2004 12:08:26 +0000 Subject: Bug 250547: Make FlagTypes use INNER JOIN instead of comma operator. Patch by Tomas Kopal r=jouni, a=justdave --- Bugzilla/FlagType.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Bugzilla/FlagType.pm') diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index a428d5389..f1cb00c5d 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -326,8 +326,8 @@ sub sqlify_criteria { # Add inclusions to the query, which simply involves joining the table # by flag type ID and target product/component. - push(@$tables, ", flaginclusions"); - push(@criteria, "flagtypes.id = flaginclusions.type_id"); + push(@$tables, "INNER JOIN flaginclusions ON " . + "flagtypes.id = flaginclusions.type_id"); push(@criteria, "(flaginclusions.product_id = $product_id " . " OR flaginclusions.product_id IS NULL)"); push(@criteria, "(flaginclusions.component_id = $component_id " . -- cgit v1.2.3-24-g4f1b