From b0642d67ae6a9a7e7bbb8b8dc7a832c26bb211af Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Mon, 1 Feb 2010 17:34:26 -0800 Subject: Bug 487508: Allow restricting the visibility of custom fields and values by component r=dkl, a=mkanat --- Bugzilla/Product.pm | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) (limited to 'Bugzilla/Product.pm') diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index c993905db..6b00fcbf6 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -32,9 +32,7 @@ use Bugzilla::Mailer; use Bugzilla::Series; use Bugzilla::Hook; -# Currently, we only implement enough of the Bugzilla::Field::Choice -# interface to control the visibility of other fields. -use base qw(Bugzilla::Field::Choice); +use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use constant DEFAULT_CLASSIFICATION_ID => 1; @@ -43,10 +41,6 @@ use constant DEFAULT_CLASSIFICATION_ID => 1; ############################### use constant DB_TABLE => 'products'; -# Reset these back to the Bugzilla::Object defaults, instead of the -# Bugzilla::Field::Choice defaults. -use constant NAME_FIELD => 'name'; -use constant LIST_ORDER => 'name'; use constant DB_COLUMNS => qw( id @@ -565,14 +559,7 @@ sub _check_votes { # Implement Bugzilla::Field::Choice # ##################################### -sub field { - my $invocant = shift; - my $class = ref $invocant || $invocant; - my $cache = Bugzilla->request_cache; - $cache->{"field_$class"} ||= new Bugzilla::Field({ name => 'product' }); - return $cache->{"field_$class"}; -} - +use constant FIELD_NAME => 'product'; use constant is_default => 0; ############################### -- cgit v1.2.3-24-g4f1b