From 333b8fcbaad05e5e3ab01a897529560dea37dd53 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Tue, 6 Jul 2010 17:13:46 -0700 Subject: Bug 552919: Sort group_concat results so that they sort correctly for buglists r=mkanat, a=mkanat (module owner) --- Bugzilla/Search.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'Bugzilla/Search.pm') diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index 61f5e995e..ad8ab0edb 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -308,10 +308,10 @@ sub COLUMNS { . " * ($actual_time / ($actual_time + bugs.remaining_time))" . " END)", - 'flagtypes.name' => $dbh->sql_group_concat('DISTINCT ' - . $dbh->sql_string_concat('flagtypes.name', 'flags.status'), "', '"), + 'flagtypes.name' => $dbh->sql_group_concat('DISTINCT ' + . $dbh->sql_string_concat('flagtypes.name', 'flags.status')), - 'keywords' => $dbh->sql_group_concat('DISTINCT keyworddefs.name', "', '"), + 'keywords' => $dbh->sql_group_concat('DISTINCT keyworddefs.name'), ); # Backward-compatibility for old field names. Goes new_name => old_name. @@ -354,8 +354,7 @@ sub COLUMNS { } elsif ($field->type == FIELD_TYPE_MULTI_SELECT) { $sql = $dbh->sql_group_concat( - 'DISTINCT map_bug_' . $field->name . '.value', - $dbh->quote(', ')); + 'DISTINCT map_bug_' . $field->name . '.value'); } else { $sql = 'bugs.' . $field->name; -- cgit v1.2.3-24-g4f1b