From 26b0e4cffe829d9c436ae28de218788c0534ee29 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Thu, 19 Nov 2009 02:09:45 +0000 Subject: Bug 529416: (CVE-2009-3386) [SECURITY] Dependency lists display bug aliases even for bugs the user cannot access Patch by Dave Miller r=LpSolit, r=mkanat, a=mkanat --- Bugzilla/Template.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'Bugzilla/Template.pm') diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index ba0a035bb..17429a2e2 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -348,10 +348,6 @@ sub get_bug_link { $bug = blessed($bug) ? $bug : new Bugzilla::Bug($bug); return $link_text if $bug->{error}; - if ($options->{use_alias} && $link_text =~ /^\d+$/ && $bug->alias) { - $link_text = $bug->alias; - } - # Initialize these variables to be "" so that we don't get warnings # if we don't change them below (which is highly likely). my ($pre, $title, $post) = ("", "", ""); @@ -369,6 +365,9 @@ sub get_bug_link { } if (Bugzilla->user->can_see_bug($bug)) { $title .= " - " . $bug->short_desc; + if ($options->{use_alias} && $link_text =~ /^\d+$/ && $bug->alias) { + $link_text = $bug->alias; + } } # Prevent code injection in the title. $title = html_quote(clean_text($title)); -- cgit v1.2.3-24-g4f1b