From f4b9806c5ab5e63383269ef328643145ade66004 Mon Sep 17 00:00:00 2001 From: Simon Green Date: Sun, 10 Aug 2014 17:42:10 +1000 Subject: Bug 897915 - Field lists not sorted alphabetically r=dkl, a=sgreen --- Bugzilla/Template.pm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'Bugzilla/Template.pm') diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index b36249b2f..52ccee593 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -611,6 +611,21 @@ $Template::Stash::LIST_OPS->{ clone } = return [@$list]; }; +# Allow us to sort the list of fields correctly +$Template::Stash::LIST_OPS->{ sort_by_field_name } = + sub { + sub field_name { + if ($_[0] eq 'noop') { + # Sort --- first + return ''; + } + # Otherwise sort by field_desc or description + return $_[1]{$_[0]} || $_[0]; + } + my ($list, $field_desc) = @_; + return [ sort { lc field_name($a, $field_desc) cmp lc field_name($b, $field_desc) } @$list ]; + }; + # Allow us to still get the scalar if we use the list operation ".0" on it, # as we often do for defaults in query.cgi and other places. $Template::Stash::SCALAR_OPS->{ 0 } = -- cgit v1.2.3-24-g4f1b