From f0e69404788bc0ac89b21423bb22f464bc78fe0a Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 28 Feb 2012 09:19:26 +0100 Subject: Bug 731055: get_enterable_products() is very slow when a product has many components or versions r/a=mkanat --- Bugzilla/User.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'Bugzilla/User.pm') diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 93142b3b7..bda055af4 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -1036,12 +1036,14 @@ sub get_enterable_products { # And all of these products must have at least one component # and one version. $enterable_ids = $dbh->selectcol_arrayref( - 'SELECT DISTINCT products.id FROM products - INNER JOIN components ON components.product_id = products.id - INNER JOIN versions ON versions.product_id = products.id - WHERE products.id IN (' . join(',', @$enterable_ids) . ') - AND components.isactive = 1 - AND versions.isactive = 1'); + 'SELECT DISTINCT products.id FROM products + WHERE ' . $dbh->sql_in('products.id', $enterable_ids) . + ' AND products.id IN (SELECT DISTINCT components.product_id + FROM components + WHERE components.isactive = 1) + AND products.id IN (SELECT DISTINCT versions.product_id + FROM versions + WHERE versions.isactive = 1)'); } $self->{enterable_products} = -- cgit v1.2.3-24-g4f1b