From 1e7b4002794930fad702718714b5d1c291bf816c Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Mon, 21 Dec 2015 22:27:52 +0000 Subject: Bug 1234325 - Backport upstream bug 1230932 to bmo/4.2 to fix providing a condition as an ID to the webservice results in a taint error --- Bugzilla/WebService/Bug.pm | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'Bugzilla/WebService/Bug.pm') diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index d7a1d8f9b..1437700ac 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -1273,6 +1273,10 @@ sub update_comment_tags { { function => 'Bug.update_comment_tags', param => 'comment_id' }); + ThrowCodeError("param_integer_required", { function => 'Bug.update_comment_tags', + param => 'comment_id' }) + unless $comment_id =~ /^[0-9]+$/; + my $comment = Bugzilla::Comment->new($comment_id) || return []; $comment->bug->check_is_visible(); -- cgit v1.2.3-24-g4f1b