From 1f20953a72a1c653fe4f4ea0a77884d91f2fffe8 Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Mon, 31 Mar 2014 15:51:20 +0000 Subject: Bug 989647 - Bug.update_attachment should allow for adding a comment when updating attachment details similar to attachment.cgi r=glob,a=justdave --- Bugzilla/WebService/Bug.pm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to 'Bugzilla/WebService/Bug.pm') diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index 3af8169b4..204e31183 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -860,6 +860,7 @@ sub update_attachment { } my $flags = delete $params->{flags}; + my $comment = delete $params->{comment}; # Update the values foreach my $attachment (@attachments) { @@ -877,6 +878,13 @@ sub update_attachment { foreach my $attachment (@attachments) { my $changes = $attachment->update(); + if ($comment = trim($comment)) { + $attachment->bug->add_comment($comment, + { isprivate => $attachment->isprivate, + type => CMT_ATTACHMENT_UPDATED, + extra_data => $attachment->id }); + } + $changes = translate($changes, ATTACHMENT_MAPPED_RETURNS); my %hash = ( @@ -904,7 +912,8 @@ sub update_attachment { # Email users about the change foreach my $bug (values %bugs) { - Bugzilla::BugMail::Send($bug->id, { 'changer' => $user }); + $bug->update(); + $bug->send_changes(); } # Return the information to the user @@ -3589,6 +3598,10 @@ in the UI for this attachment. C A short string describing the attachment. +=item C + +C An optional comment to add to the attachment's bug. + =item C C The MIME type of the attachment, like -- cgit v1.2.3-24-g4f1b