From c94abb0445d015c1bffcd7207eac6fd9a3a8371b Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Tue, 22 Dec 2015 20:57:02 +0000 Subject: Revert "Bug 1230932 - Providing a condition as an ID to the webservice results in a taint error" This reverts commit eb1357fe03bb47cdd479cf533022e11dd6bd22e0. --- Bugzilla/WebService/Util.pm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'Bugzilla/WebService/Util.pm') diff --git a/Bugzilla/WebService/Util.pm b/Bugzilla/WebService/Util.pm index 503246c16..cbbc47921 100644 --- a/Bugzilla/WebService/Util.pm +++ b/Bugzilla/WebService/Util.pm @@ -18,7 +18,6 @@ use Bugzilla::WebService::Constants; use Storable qw(dclone); use URI::Escape qw(uri_unescape); -use List::MoreUtils qw(all any); use parent qw(Exporter); @@ -222,8 +221,7 @@ sub validate { # sent any parameters at all, and we're getting @keys where # $params should be. return ($self, undef) if (defined $params and !ref $params); - - my @id_params = qw( ids comment_ids ); + # If @keys is not empty then we convert any named # parameters that have scalar values to arrayrefs # that match. @@ -232,12 +230,6 @@ sub validate { $params->{$key} = ref $params->{$key} ? $params->{$key} : [ $params->{$key} ]; - - if (any { $key eq $_ } @id_params) { - my $ids = $params->{$key}; - ThrowCodeError('param_integer_array_required', { param => $key }) - unless ref($ids) eq 'ARRAY' && all { /^[0-9]+$/ } @$ids; - } } } -- cgit v1.2.3-24-g4f1b