From 2f65ef51e9ba430783a2d9ef06e0aa0af041d510 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Tue, 17 Mar 2015 11:54:20 +0800 Subject: Bug 1142399: invalid xmlrpc requests warns: Use of uninitialized value $file in substitution (s///) (Bugzilla/WebService/Server/XMLRPC.pm:114) r=dkl,a=glob --- Bugzilla/WebService/Server/XMLRPC.pm | 3 +++ 1 file changed, 3 insertions(+) (limited to 'Bugzilla/WebService') diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index a49ac2033..f3d95ef3d 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -98,6 +98,9 @@ sub make_response { sub handle_login { my ($self, $classes, $action, $uri, $method) = @_; my $class = $classes->{$uri}; + if (!$class) { + ThrowCodeError('unknown_method', { method => $method eq 'methodName' ? '' : '.' . $method }); + } my $full_method = $uri . "." . $method; # Only allowed methods to be used from the module's whitelist my $file = $class; -- cgit v1.2.3-24-g4f1b