From e15dcf488f8bbf1fef2cd0a7001385f7a95e8d59 Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Wed, 17 Aug 2011 00:45:22 +0200 Subject: Bug 678970: Use $user and $cgi instead of Bugzilla->user and Bugzilla->cgi r=timello a=LpSolit --- Bugzilla/WebService/Bug.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'Bugzilla/WebService') diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index 9064f6a14..7844b4e97 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -670,10 +670,10 @@ sub add_attachment { sub add_comment { my ($self, $params) = @_; - - #The user must login in order add a comment - Bugzilla->login(LOGIN_REQUIRED); - + + # The user must login in order add a comment + my $user = Bugzilla->login(LOGIN_REQUIRED); + # Check parameters defined $params->{id} || ThrowCodeError('param_required', { param => 'id' }); @@ -682,8 +682,8 @@ sub add_comment { || ThrowCodeError('param_required', { param => 'comment' }); my $bug = Bugzilla::Bug->check($params->{id}); - - Bugzilla->user->can_edit_product($bug->product_id) + + $user->can_edit_product($bug->product_id) || ThrowUserError("product_edit_denied", {product => $bug->product}); # Backwards-compatibility for versions before 3.6 @@ -707,8 +707,8 @@ sub add_comment { $dbh->bz_commit_transaction(); # Send mail. - Bugzilla::BugMail::Send($bug->bug_id, { changer => Bugzilla->user }); - + Bugzilla::BugMail::Send($bug->bug_id, { changer => $user }); + return { id => $self->type('int', $new_comment_id) }; } -- cgit v1.2.3-24-g4f1b