From 0fa7022e791499766365c85a7b36bb4cd22a7bcc Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Mon, 21 Jun 2010 19:44:04 -0700 Subject: Bug 573454: Make the products.description field be NOT NULL in the database r=timello, a=mkanat --- Bugzilla/DB/Schema.pm | 2 +- Bugzilla/Install/DB.pm | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) (limited to 'Bugzilla') diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm index c354c1beb..9fc507885 100644 --- a/Bugzilla/DB/Schema.pm +++ b/Bugzilla/DB/Schema.pm @@ -1217,7 +1217,7 @@ use constant ABSTRACT_SCHEMA => { REFERENCES => {TABLE => 'classifications', COLUMN => 'id', DELETE => 'CASCADE'}}, - description => {TYPE => 'MEDIUMTEXT'}, + description => {TYPE => 'MEDIUMTEXT', NOTNULL => 1}, isactive => {TYPE => 'BOOLEAN', NOTNULL => 1, DEFAULT => 1}, defaultmilestone => {TYPE => 'varchar(20)', diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index 7599199ab..069096800 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -616,10 +616,14 @@ sub update_table_definitions { $dbh->bz_alter_column('group_control_map', 'othercontrol', {TYPE => 'INT1', NOTNULL => 1, DEFAULT => CONTROLMAPNA}); + # Add NOT NULL to some columns that need it, and DEFAULT to + # attachments.ispatch. $dbh->bz_alter_column('attachments', 'ispatch', { TYPE => 'BOOLEAN', NOTNULL => 1, DEFAULT => 'FALSE'}); $dbh->bz_alter_column('keyworddefs', 'description', { TYPE => 'MEDIUMTEXT', NOTNULL => 1 }, ''); + $dbh->bz_alter_column('products', 'description', + { TYPE => 'MEDIUMTEXT', NOTNULL => 1 }, ''); ################################################################ # New --TABLE-- changes should go *** A B O V E *** this point # -- cgit v1.2.3-24-g4f1b