From 108eb83fae1e54f9746698246551e188dede26cb Mon Sep 17 00:00:00 2001 From: Reed Loden Date: Mon, 5 Jul 2010 19:44:13 -0500 Subject: Bug 554964 - Show if a user is a "Default CC" under the Product Responsibilities section of editusers.cgi. [r=mkanat a=mkanat] --- Bugzilla/Template.pm | 12 ++++++++++-- Bugzilla/User.pm | 11 +++++++---- 2 files changed, 17 insertions(+), 6 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index 71ade2f01..4bd3d2d77 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -380,14 +380,22 @@ $Template::Stash::PRIVATE = undef; $Template::Stash::LIST_OPS->{ contains } = sub { my ($list, $item) = @_; - return grep($_ eq $item, @$list); + if (ref $item && $item->isa('Bugzilla::Object')) { + return grep($_->id == $item->id, @$list); + } else { + return grep($_ eq $item, @$list); + } }; $Template::Stash::LIST_OPS->{ containsany } = sub { my ($list, $items) = @_; foreach my $item (@$items) { - return 1 if grep($_ eq $item, @$list); + if (ref $item && $item->isa('Bugzilla::Object')) { + return 1 if grep($_->id == $item->id, @$list); + } else { + return 1 if grep($_ eq $item, @$list); + } } return 0; }; diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index cb3f75fa8..b9405e412 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -1152,11 +1152,14 @@ sub product_responsibilities { return $self->{'product_resp'} if defined $self->{'product_resp'}; return [] unless $self->id; - my $list = $dbh->selectall_arrayref('SELECT product_id, id + my $list = $dbh->selectall_arrayref('SELECT components.product_id, components.id FROM components - WHERE initialowner = ? - OR initialqacontact = ?', - {Slice => {}}, ($self->id, $self->id)); + LEFT JOIN component_cc + ON components.id = component_cc.component_id + WHERE components.initialowner = ? + OR components.initialqacontact = ? + OR component_cc.user_id = ?', + {Slice => {}}, ($self->id, $self->id, $self->id)); unless ($list) { $self->{'product_resp'} = []; -- cgit v1.2.3-24-g4f1b