From 1633d9835c4ab45d583ba4b6d8b585d66925a5b2 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Mon, 6 Apr 2009 20:02:51 +0000 Subject: Bug 486881: A powerless user can still see a restricted bug when he removes all his roles related to the bug - Patch by Frédéric Buclin r/a=mkanat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Bug.pm | 4 ++++ Bugzilla/User.pm | 2 ++ 2 files changed, 6 insertions(+) (limited to 'Bugzilla') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 5038275c8..79cf1dd5e 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -876,6 +876,10 @@ sub update { delete $self->{'_old_assigned_to'}; delete $self->{'_old_qa_contact'}; + # Also flush the visible_bugs cache for this bug as the user's + # relationship with this bug may have changed. + delete Bugzilla->user->{_visible_bugs_cache}->{$self->id}; + return $changes; } diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 74289fe56..cf4cb5fa6 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -588,6 +588,8 @@ sub visible_bugs { # We only check the visibility of bugs that we haven't # checked yet. + # Bugzilla::Bug->update automatically removes updated bugs + # from the cache to force them to be checked again. my $visible_cache = $self->{_visible_bugs_cache} ||= {}; my @check_ids = grep(!exists $visible_cache->{$_}, @bug_ids); -- cgit v1.2.3-24-g4f1b