From 1f6e1616c3e2f66d1982809a8d399129911d242b Mon Sep 17 00:00:00 2001 From: "myk%mozilla.org" <> Date: Fri, 22 Apr 2005 09:17:14 +0000 Subject: Fix for bug 291391: allows users to rerequest set flags even if they don't have the privilege to set them; r=lpsolit; a=myk --- Bugzilla/Flag.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index de9c3d23b..8e03284d0 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -320,9 +320,9 @@ sub validate { # - The flag is unchanged next if ($status eq $flag->{status}); - # - User in the $request_gid group can clear pending requests - next if ($status eq 'X' - && $flag->{status} eq '?' + # - User in the $request_gid group can clear pending requests and set flags + # and can rerequest set flags. + next if (($status eq 'X' || $status eq '?') && (!$flag->{type}->{request_gid} || $user->in_group(&::GroupIdToName($flag->{type}->{request_gid})))); -- cgit v1.2.3-24-g4f1b