From 22212e5112de8a21d1727a0ea090a8a37253751b Mon Sep 17 00:00:00 2001
From: "bugreport%peshkin.net" <>
Date: Thu, 20 Oct 2005 03:04:20 +0000
Subject: Bug 313008 Lists of products, milestones, etc... should be sorted
 Patch by Joel Peshkin <bugreport@peshkin.net> r=lpsolit, a=justdave

---
 Bugzilla/Classification.pm | 3 ++-
 Bugzilla/Product.pm        | 9 ++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

(limited to 'Bugzilla')

diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm
index fae932b85..e87852ba2 100644
--- a/Bugzilla/Classification.pm
+++ b/Bugzilla/Classification.pm
@@ -100,7 +100,8 @@ sub products {
     if (!$self->{'products'}) {
         my $product_ids = $dbh->selectcol_arrayref(q{
             SELECT id FROM products
-            WHERE classification_id = ?}, undef, $self->id);
+            WHERE classification_id = ?
+            ORDER BY name}, undef, $self->id);
  
         my @products;
         foreach my $product_id (@$product_ids) {
diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm
index f55b5dd67..2bc9da52d 100644
--- a/Bugzilla/Product.pm
+++ b/Bugzilla/Product.pm
@@ -100,7 +100,8 @@ sub components {
     if (!defined $self->{components}) {
         my $ids = $dbh->selectcol_arrayref(q{
             SELECT id FROM components
-            WHERE product_id = ?}, undef, $self->id);
+            WHERE product_id = ?
+            ORDER BY name}, undef, $self->id);
 
         my @components;
         foreach my $id (@$ids) {
@@ -145,7 +146,8 @@ sub versions {
     if (!defined $self->{versions}) {
         my $values = $dbh->selectcol_arrayref(q{
             SELECT value FROM versions
-            WHERE product_id = ?}, undef, $self->id);
+            WHERE product_id = ?
+            ORDER BY value}, undef, $self->id);
 
         my @versions;
         foreach my $value (@$values) {
@@ -163,7 +165,8 @@ sub milestones {
     if (!defined $self->{milestones}) {
         my $values = $dbh->selectcol_arrayref(q{
             SELECT value FROM milestones
-            WHERE product_id = ?}, undef, $self->id);
+            WHERE product_id = ?
+            ORDER BY sortkey}, undef, $self->id);
  
         my @milestones;
         foreach my $value (@$values) {
-- 
cgit v1.2.3-24-g4f1b