From 292ad609ffad27232699a5c5db2b244a28881267 Mon Sep 17 00:00:00 2001 From: Byron Jones Date: Mon, 7 Jan 2013 13:46:38 +0800 Subject: Bug 825718: Fix Bugzilla::Bug->check() wrt caching mechanism r=LpSolit,r=LpSolit --- Bugzilla/Bug.pm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 7c7e0fb37..4485b620c 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -372,14 +372,16 @@ sub cache_key { sub check { my $class = shift; - my ($id, $field) = @_; - - ThrowUserError('improper_bug_id_field_value', { field => $field }) unless defined $id; + my ($param, $field) = @_; # Bugzilla::Bug throws lots of special errors, so we don't call # SUPER::check, we just call our new and do our own checks. - $id = trim($id); - my $self = $class->new($id); + my $id = ref($param) + ? ($param->{id} = trim($param->{id})) + : ($param = trim($param)); + ThrowUserError('improper_bug_id_field_value', { field => $field }) unless defined $id; + + my $self = $class->new($param); if ($self->{error}) { # For error messages, use the id that was returned by new(), because -- cgit v1.2.3-24-g4f1b