From 30987a363fbcb5a3c3a15a69b4a0e3cdac956da8 Mon Sep 17 00:00:00 2001 From: Date: Fri, 31 Aug 2012 16:41:55 -0400 Subject: Bug 783222 - Make set_all() throw error on invalid param names r/a=LpSolit --- Bugzilla/Object.pm | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'Bugzilla') diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index c606540fa..531b81711 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -321,12 +321,17 @@ sub set_all { my %field_values = %$params; my @sorted_names = $self->_sort_by_dep(keys %field_values); + foreach my $key (@sorted_names) { # It's possible for one set_ method to delete a key from $params # for another set method, so if that's happened, we don't call the # other set method. next if !exists $field_values{$key}; my $method = "set_$key"; + if (!$self->can($method)) { + my $class = ref($self) || $self; + ThrowCodeError("unknown_method", { method => "${class}::${method}" }); + } $self->$method($field_values{$key}, \%field_values); } Bugzilla::Hook::process('object_end_of_set_all', -- cgit v1.2.3-24-g4f1b