From 3af55bfe0bd10a85b7cd69e26a19034a6d2e78f5 Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Mon, 21 Mar 2016 15:53:10 +0000 Subject: Bug 1252782 - can't add a "See Also" to a Chromium bug on bugs.chromium.org --- Bugzilla/BugUrl.pm | 1 + Bugzilla/BugUrl/Chromium.pm | 49 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 Bugzilla/BugUrl/Chromium.pm (limited to 'Bugzilla') diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index 2475390f2..c19f771f5 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -64,6 +64,7 @@ use constant SUB_CLASSES => qw( Bugzilla::BugUrl::Bugzilla Bugzilla::BugUrl::Launchpad Bugzilla::BugUrl::Google + Bugzilla::BugUrl::Chromium Bugzilla::BugUrl::Debian Bugzilla::BugUrl::JIRA Bugzilla::BugUrl::Trac diff --git a/Bugzilla/BugUrl/Chromium.pm b/Bugzilla/BugUrl/Chromium.pm new file mode 100644 index 000000000..5560df24c --- /dev/null +++ b/Bugzilla/BugUrl/Chromium.pm @@ -0,0 +1,49 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# This Source Code Form is "Incompatible With Secondary Licenses", as +# defined by the Mozilla Public License, v. 2.0. + +package Bugzilla::BugUrl::Chromium; + +use 5.10.1; +use strict; +use warnings; + +use base qw(Bugzilla::BugUrl); + +use Bugzilla::Error; +use Bugzilla::Util; + +############################### +#### Methods #### +############################### + +sub should_handle { + my ($class, $uri) = @_; + return ($uri->authority =~ /^bugs.chromium.org$/i) ? 1 : 0; +} + +sub _check_value { + my ($class, $uri) = @_; + + $uri = $class->SUPER::_check_value($uri); + + my $value = $uri->as_string; + my $project_name; + if ($uri->path =~ m|^/p/([^/]+)/issues/detail$|) { + $project_name = $1; + } else { + ThrowUserError('bug_url_invalid', { url => $value }); + } + my $bug_id = $uri->query_param('id'); + detaint_natural($bug_id); + if (!$bug_id) { + ThrowUserError('bug_url_invalid', { url => $value, reason => 'id' }); + } + + return URI->new($value); +} + +1; -- cgit v1.2.3-24-g4f1b