From 46c78a8c7c42bfdf47ee1f68939aa122371b9662 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Mon, 8 May 2006 02:56:04 +0000 Subject: Bug 332521: Remove GroupIdToName() from globals.pl - Patch by Frédéric Buclin r=mkanat a=myk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Flag.pm | 4 ++-- Bugzilla/FlagType.pm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index 97d8e8c7c..9d55fcf33 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -374,12 +374,12 @@ sub validate { # and can rerequest set flags. next if (($status eq 'X' || $status eq '?') && (!$flag->{type}->{request_gid} - || $user->in_group(&::GroupIdToName($flag->{type}->{request_gid})))); + || $user->in_group_id($flag->{type}->{request_gid}))); # - User in the $grant_gid group can set/clear flags, # including "+" and "-" next if (!$flag->{type}->{grant_gid} - || $user->in_group(&::GroupIdToName($flag->{type}->{grant_gid}))); + || $user->in_group_id($flag->{type}->{grant_gid})); # - Any other flag modification is denied ThrowUserError("flag_update_denied", diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index b18c4a2de..313006377 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -431,12 +431,12 @@ sub validate { # Make sure the user is authorized to modify flags, see bug 180879 # - User in the $grant_gid group can set flags, including "+" and "-" next if (!$flag_type->{grant_gid} - || $user->in_group(&::GroupIdToName($flag_type->{grant_gid}))); + || $user->in_group_id($flag_type->{grant_gid})); # - User in the $request_gid group can request flags next if ($status eq '?' && (!$flag_type->{request_gid} - || $user->in_group(&::GroupIdToName($flag_type->{request_gid})))); + || $user->in_group_id($flag_type->{request_gid}))); # - Any other flag modification is denied ThrowUserError("flag_update_denied", -- cgit v1.2.3-24-g4f1b