From 4d04866100b1566d062f7b10c561877c49a9c6a5 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Mon, 3 Aug 2009 15:13:50 +0000 Subject: Bug 508032: Speed up initializing of email_setting values Patch by Max Kanat-Alexander (module owner) a=mkanat --- Bugzilla/Install/DB.pm | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index 09b110894..48fc06630 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -2222,17 +2222,9 @@ sub _clone_email_event { my ($source, $target) = @_; my $dbh = Bugzilla->dbh; - my $sth1 = $dbh->prepare("SELECT user_id, relationship FROM email_setting - WHERE event = $source"); - my $sth2 = $dbh->prepare("INSERT into email_setting " . - "(user_id, relationship, event) VALUES (" . - "?, ?, $target)"); - - $sth1->execute(); - - while (my ($userid, $relationship) = $sth1->fetchrow_array()) { - $sth2->execute($userid, $relationship); - } + $dbh->do("INSERT INTO email_setting (user_id, relationship, event) + SELECT user_id, relationship, $target FROM email_setting + WHERE event = $source"); } sub _migrate_email_prefs_to_new_table { -- cgit v1.2.3-24-g4f1b