From 6d11d68f570d4d921f078a67ce1928703df4bf2e Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Mon, 1 Feb 2010 13:19:31 -0800 Subject: Bug 532493: [SECURITY] Restricting a bug to a group while moving it to another product has no effect if the group is not used by both products Patch by Frédéric Buclin r=mkanat a=LpSolit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Bugzilla/Bug.pm | 27 --------------------------- 1 file changed, 27 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 1eaafb698..fd28b5b82 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -643,33 +643,6 @@ sub run_create_validators { return $params; } -sub set_all { - my ($self, $args) = @_; - - # For security purposes, and because lots of other checks depend on it, - # we set the product first before anything else. - my $product_change = 0; - if ($args->{product}) { - my $changed = $self->set_product($args->{product}, - { component => $args->{component}, - version => $args->{version}, - target_milestone => $args->{target_milestone}, - change_confirmed => $args->{confirm_product_change}, - other_bugs => $args->{other_bugs}, - }); - # that will be used later to check strict isolation - $product_change = $changed; - } - - # add/remove groups - $self->remove_group($_) foreach @{$args->{remove_group}}; - $self->add_group($_) foreach @{$args->{add_group}}; - - # this is temporary until all related code is moved from - # process_bug.cgi to set_all - return $product_change; -} - sub update { my $self = shift; -- cgit v1.2.3-24-g4f1b