From 898e5ab5f292d8d0d72ae0aa9fc6d4638e5d6eca Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Sat, 1 Oct 2011 13:22:13 +0200 Subject: Bug 582529: Ambiguous error message "You did not specify a file to attach" when deleting an existing attachment filename a=LpSolit --- Bugzilla/Attachment.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index a39dc3af4..3a8e7d5d5 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -565,7 +565,14 @@ sub _check_filename { my ($invocant, $filename) = @_; $filename = clean_text($filename); - $filename || ThrowUserError('file_not_specified'); + if (!$filename) { + if (ref $invocant) { + ThrowUserError('filename_not_specified'); + } + else { + ThrowUserError('file_not_specified'); + } + } # Remove path info (if any) from the file name. The browser should do this # for us, but some are buggy. This may not work on Mac file names and could -- cgit v1.2.3-24-g4f1b From 763a930131864bedd3155b668fcd8fd0fce2fefc Mon Sep 17 00:00:00 2001 From: Frédéric Buclin Date: Tue, 4 Oct 2011 23:38:17 +0200 Subject: $user->is_mover no longer exists, see bug 556422 --- Bugzilla/User.pm | 6 ------ 1 file changed, 6 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index ea186a0fd..48ce41a57 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -2488,12 +2488,6 @@ Returns true if the user wants mail for a given set of events. This method is more general than C, allowing you to check e.g. permissions for flag mail. -=item C - -Returns true if the user is in the list of users allowed to move bugs -to another database. Note that this method doesn't check whether bug -moving is enabled. - =item C Returns true if the user can access private comments and attachments, -- cgit v1.2.3-24-g4f1b