From 8bdb86fdce8ad3b177a81f3cf07bf026e2faa0e2 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Fri, 9 Jul 2010 22:07:51 -0700 Subject: Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm, because they are created by an aggregate. (This fixes multi-select buglist columns on Pg.) r=mkanat, a=mkanat (module owner) --- Bugzilla/Search.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index 63e458655..c41579efe 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -1119,8 +1119,12 @@ sub init { foreach my $field (@fields) { # These fields never go into the GROUP BY (bug_id goes in # explicitly, below). - next if (grep($_ eq $field, EMPTY_COLUMN, - qw(bug_id actual_time percentage_complete flagtypes.name keywords))); + my @skip_group_by = (EMPTY_COLUMN, + qw(bug_id actual_time percentage_complete flagtypes.name + keywords)); + push(@skip_group_by, map { $_->name } @$multi_select_fields); + + next if grep { $_ eq $field } @skip_group_by; my $col = COLUMNS->{$field}->{name}; push(@groupby, $col) if !grep($_ eq $col, @groupby); } -- cgit v1.2.3-24-g4f1b