From aff82a963b8ef1561b346eea5627ee189ce405f8 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Fri, 23 Jan 2009 03:27:45 +0000 Subject: Fix some nits that I forgot to fix on checkin for bug 474715. --- Bugzilla/Object.pm | 3 +-- Bugzilla/WebService/Bug.pm | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index 75e04f2e7..adc96fa50 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -168,7 +168,6 @@ sub match { next; } elsif ( $field eq 'WHERE' ) { - next unless $value; # the WHERE value is a hashref where the keys are # "column_name operator ?" and values are the placeholder's # value. @@ -662,7 +661,7 @@ clauses to the underlying query. Its value is expected to a hash reference whose keys are the columns, operators and placeholders, and the values are the placeholders' bind value. For example: - WHERE => {'some_column >= ?' => $some_value } + WHERE => { 'some_column >= ?' => $some_value } would constrain the query to only those objects in the table whose 'some_column' column has a value greater than or equal to $some_value. diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index 31f87ba99..1c0df32ac 100755 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -221,8 +221,9 @@ sub get_history { sub search { my ($self, $params) = @_; - if ( $params->{offset} and !$params->{limit} ) { - ThrowCodeError( 'param_required', { param => 'limit', function => 'Bug.search()'}); + if ( defined($params->{offset}) and !defined($params->{limit}) ) { + ThrowCodeError('param_required', + { param => 'limit', function => 'Bug.search()' }); } $params = _map_fields($params); -- cgit v1.2.3-24-g4f1b