From db6b722ddca04ee1d067e010abc3e8e7fd9384c4 Mon Sep 17 00:00:00 2001 From: Jeff Fearn Date: Wed, 3 Jun 2015 23:01:41 +0800 Subject: Bug 1089475: Use "ThrowCodeError" when a database error occurs instead of dumping a stack trace r=glob,a=glob --- Bugzilla/DB.pm | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'Bugzilla') diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index 9f3ed0f49..adf55f351 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -142,6 +142,14 @@ sub _handle_error { $_[0] = substr($_[0], 0, 2000) . ' ... ' . substr($_[0], -2000) if length($_[0]) > 4000; $_[0] = Carp::longmess($_[0]); + + if (!Bugzilla->request_cache->{in_error} && Bugzilla->usage_mode == USAGE_MODE_BROWSER) { + Bugzilla->request_cache->{in_error} = 1; + ThrowCodeError("db_error", {err_message => $_[0]}); + } + + Bugzilla->request_cache->{in_error} = undef; + return 0; # Now let DBI handle raising the error } -- cgit v1.2.3-24-g4f1b