From f1973062b3ccda18738e188738da55af12b90f96 Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Thu, 7 Oct 2010 05:56:47 -0700 Subject: Bug 600495: Make the "chfieldto" query parameter work all by itself, again. r=mkanat, a=mkanat (module owner) --- Bugzilla/Search.pm | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'Bugzilla') diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index cc1354dcf..850a63457 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -1309,14 +1309,20 @@ sub _special_parse_chfield { # if there is a "from" date specified. It doesn't conflict with # searching [Bug creation], because a bug's delta_ts is set to # its creation_ts when it is created. So this just gives the - # database an additional index to possibly choose. - # - # It's not safe to do it for "to" dates, though--"chfieldto" means - # "a field that changed before this date", and delta_ts could be either - # later or earlier than that. + # database an additional index to possibly choose, on a table that + # is smaller than bugs_activity. if ($date_from ne '') { push(@charts, ['delta_ts', 'greaterthaneq', $date_from]); } + # It's not normally safe to do it for "to" dates, though--"chfieldto" means + # "a field that changed before this date", and delta_ts could be either + # later or earlier than that, if we're searching for the time that a field + # changed. However, chfieldto all by itself, without any chfieldvalue or + # chfield, means "just search delta_ts", and so we still want that to + # work. + if ($date_to ne '' and !@fields and $value_to eq '') { + push(@charts, ['delta_ts', 'lessthaneq', $date_to]); + } # Basically, we construct the chart like: # -- cgit v1.2.3-24-g4f1b