From f578f79698f5779f20ee8354a3af132fafaf66da Mon Sep 17 00:00:00 2001
From: Simon Green <mail@simon.green>
Date: Wed, 29 Jul 2015 05:31:14 -0400
Subject: Bug 399078 - Remove the 'musthavemilestoneonaccept' parameter r=gerv,
 a=simon

---
 Bugzilla/API/1_0/Resource/Bugzilla.pm |  2 --
 Bugzilla/Bug.pm                       | 14 --------------
 Bugzilla/Config/BugChange.pm          |  6 ------
 Bugzilla/WebService/Bugzilla.pm       |  2 --
 4 files changed, 24 deletions(-)

(limited to 'Bugzilla')

diff --git a/Bugzilla/API/1_0/Resource/Bugzilla.pm b/Bugzilla/API/1_0/Resource/Bugzilla.pm
index b2e7105f6..de9925e69 100644
--- a/Bugzilla/API/1_0/Resource/Bugzilla.pm
+++ b/Bugzilla/API/1_0/Resource/Bugzilla.pm
@@ -76,7 +76,6 @@ use constant PARAMETERS_LOGGED_IN => qw(
     maintainer
     maxattachmentsize
     maxlocalattachment
-    musthavemilestoneonaccept
     noresolveonopenblockers
     password_complexity
     rememberlogin
@@ -458,7 +457,6 @@ A logged-in user can access the following parameters (listed alphabetically):
     C<maintainer>,
     C<maxattachmentsize>,
     C<maxlocalattachment>,
-    C<musthavemilestoneonaccept>,
     C<noresolveonopenblockers>,
     C<password_complexity>,
     C<rememberlogin>,
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index ff8f651e4..2cc9aadb0 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -1529,20 +1529,6 @@ sub _check_bug_status {
           { old => $old_status ? $old_status->name : undef,
             new => $new_status->name, field => 'bug_status' });
     }
-    
-    if (ref $invocant 
-        && ($new_status->name eq 'IN_PROGRESS'
-            # Backwards-compat for the old default workflow.
-            or $new_status->name eq 'ASSIGNED')
-        && Bugzilla->params->{"usetargetmilestone"}
-        && Bugzilla->params->{"musthavemilestoneonaccept"}
-        # musthavemilestoneonaccept applies only if at least two
-        # target milestones are defined for the product.
-        && scalar(@{ $product->milestones }) > 1
-        && $invocant->target_milestone eq $product->default_milestone)
-    {
-        ThrowUserError("milestone_required", { bug => $invocant });
-    }
 
     if (!blessed $invocant) {
         $params->{everconfirmed} = $new_status->name eq 'UNCONFIRMED' ? 0 : 1;
diff --git a/Bugzilla/Config/BugChange.pm b/Bugzilla/Config/BugChange.pm
index 212f4c171..6126b7f35 100644
--- a/Bugzilla/Config/BugChange.pm
+++ b/Bugzilla/Config/BugChange.pm
@@ -53,12 +53,6 @@ sub get_param_list {
    default => 1
   },
 
-  {
-   name => 'musthavemilestoneonaccept',
-   type => 'b',
-   default => 0
-  },
-
   {
    name => 'commentonchange_resolution',
    type => 'b',
diff --git a/Bugzilla/WebService/Bugzilla.pm b/Bugzilla/WebService/Bugzilla.pm
index e1d1b62a1..a9cef32fc 100644
--- a/Bugzilla/WebService/Bugzilla.pm
+++ b/Bugzilla/WebService/Bugzilla.pm
@@ -70,7 +70,6 @@ use constant PARAMETERS_LOGGED_IN => qw(
     maintainer
     maxattachmentsize
     maxlocalattachment
-    musthavemilestoneonaccept
     password_complexity
     rememberlogin
     requirelogin
@@ -427,7 +426,6 @@ A logged-in user can access the following parameters (listed alphabetically):
     C<maintainer>,
     C<maxattachmentsize>,
     C<maxlocalattachment>,
-    C<musthavemilestoneonaccept>,
     C<password_complexity>,
     C<rememberlogin>,
     C<requirelogin>,
-- 
cgit v1.2.3-24-g4f1b