From 14ece482a9028897f3877e157fdad172f9eeb6eb Mon Sep 17 00:00:00 2001 From: Dave Lawrence Date: Tue, 7 Jan 2014 00:13:41 -0500 Subject: Bug 956052 - backport upstream bug 945535 to bmo/4.2 for performance improvement in bugs with large number of attachments --- attachment.cgi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'attachment.cgi') diff --git a/attachment.cgi b/attachment.cgi index 57706d5e0..18ac6f57a 100755 --- a/attachment.cgi +++ b/attachment.cgi @@ -459,9 +459,8 @@ sub diff { sub viewall { # Retrieve and validate parameters my $bug = Bugzilla::Bug->check({ id => scalar $cgi->param('bugid'), cache => 1 }); - my $bugid = $bug->id; - my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bugid); + my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug); # Ignore deleted attachments. @$attachments = grep { $_->datasize } @$attachments; @@ -637,7 +636,7 @@ sub edit { my $attachment = validateID(); my $bugattachments = - Bugzilla::Attachment->get_attachments_by_bug($attachment->bug_id); + Bugzilla::Attachment->get_attachments_by_bug($attachment->bug); my $any_flags_requesteeble = grep { $_->is_requestable && $_->is_requesteeble } @{$attachment->flag_types}; -- cgit v1.2.3-24-g4f1b