From 672d71471ee2ddae6005a9259789899c41264823 Mon Sep 17 00:00:00 2001
From: "travis%sedsystems.ca" <>
Date: Thu, 10 Mar 2005 00:18:03 +0000
Subject: Bug 282574 : use the new "auth_failure" error message for all
 authentication failures Patch by Frederic Buclin <LpSolit@gmail.com>  
 r=travis, wurblzap  a=myk

---
 attachment.cgi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

(limited to 'attachment.cgi')

diff --git a/attachment.cgi b/attachment.cgi
index 64e30f64a..5e4c520f5 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -204,9 +204,10 @@ sub validateID
     # Make sure the user is authorized to access this attachment's bug.
     ($bugid, my $isprivate) = FetchSQLData();
     ValidateBugID($bugid);
-    if (($isprivate > 0 ) && Param("insidergroup") && 
-        !(UserInGroup(Param("insidergroup")))) {
-        ThrowUserError("attachment_access_denied");
+    if ($isprivate && Param("insidergroup")) {
+        UserInGroup(Param("insidergroup"))
+          || ThrowUserError("auth_failure", {action => "access",
+                                             object => "attachment"});
     }
 
     # XXX shim code, kill $::FORM
-- 
cgit v1.2.3-24-g4f1b