From 181d044266e61ffa073d1aa7ba252e812ac03c65 Mon Sep 17 00:00:00 2001
From: "bbaetz%student.usyd.edu.au" <>
Date: Fri, 5 Apr 2002 15:48:27 +0000
Subject: bug 134562 - taint error in buglist.cgi r=justdave, gerv

---
 buglist.cgi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'buglist.cgi')

diff --git a/buglist.cgi b/buglist.cgi
index 2895ddd81..53685e96d 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -1226,8 +1226,12 @@ else {
 # Add the votes column to the list of columns to be displayed
 # in the bug list if the user is searching for bugs with a certain
 # number of votes and the votes column is not already on the list.
-push(@displaycolumns, 'votes') 
-  if $::FORM{'votes'} && !grep($_ eq 'votes', @displaycolumns);
+
+# Some versions of perl will taint 'votes' if this is done as a single
+# statement, because $::FORM{'votes'} is tainted at this point
+if (trim($::FORM{'votes'}) && !grep($_ eq 'votes', @displaycolumns)) {
+    push(@displaycolumns, 'votes');
+}
 
 
 ################################################################################
-- 
cgit v1.2.3-24-g4f1b