From 271477d8c26794abd8310e2abb89b746204660af Mon Sep 17 00:00:00 2001 From: Max Kanat-Alexander Date: Thu, 22 Apr 2010 11:02:17 -0700 Subject: Bug 560009: Use firstidx from List::MoreUtils instead of lsearch r=timello, a=mkanat --- buglist.cgi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'buglist.cgi') diff --git a/buglist.cgi b/buglist.cgi index 3090b2a88..576b95572 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -683,7 +683,7 @@ my @selectcolumns = ("bug_id", "bug_severity", "priority", "bug_status", "resolution", "product"); # remaining and actual_time are required for percentage_complete calculation: -if (lsearch(\@displaycolumns, "percentage_complete") >= 0) { +if (grep { $_ eq "percentage_complete" } @displaycolumns) { push (@selectcolumns, "remaining_time"); push (@selectcolumns, "actual_time"); } @@ -906,12 +906,12 @@ $buglist_sth->execute(); # of Perl records. # If we're doing time tracking, then keep totals for all bugs. -my $percentage_complete = lsearch(\@displaycolumns, 'percentage_complete') >= 0; -my $estimated_time = lsearch(\@displaycolumns, 'estimated_time') >= 0; -my $remaining_time = ((lsearch(\@displaycolumns, 'remaining_time') >= 0) - || $percentage_complete); -my $actual_time = ((lsearch(\@displaycolumns, 'actual_time') >= 0) - || $percentage_complete); +my $percentage_complete = grep($_ eq 'percentage_complete', @displaycolumns); +my $estimated_time = grep($_ eq 'estimated_time', @displaycolumns); +my $remaining_time = grep($_ eq 'remaining_time', @displaycolumns) + || $percentage_complete; +my $actual_time = grep($_ eq 'actual_time', @displaycolumns) + || $percentage_complete; my $time_info = { 'estimated_time' => 0, 'remaining_time' => 0, -- cgit v1.2.3-24-g4f1b