From 38eeecf6362b6dc17718c84a35dbbaea7cc15ccd Mon Sep 17 00:00:00 2001 From: Reed Loden Date: Mon, 24 Jan 2011 10:12:00 -0800 Subject: Bug 621572: (CVE-2010-4572) [SECURITY] chart.cgi vulnerable to header-injection due to use of |print "Location:"| instead of $cgi->redirect [r=mkanat a=LpSolit] --- chart.cgi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'chart.cgi') diff --git a/chart.cgi b/chart.cgi index a04cde068..e7a0f5e8b 100755 --- a/chart.cgi +++ b/chart.cgi @@ -74,8 +74,8 @@ if (!Bugzilla->feature('new_charts')) { # Go back to query.cgi if we are adding a boolean chart parameter. if (grep(/^cmd-/, $cgi->param())) { my $params = $cgi->canonicalise_query("format", "ctype", "action"); - print "Location: query.cgi?format=" . $cgi->param('query_format') . - ($params ? "&$params" : "") . "\n\n"; + print $cgi->redirect("query.cgi?format=" . $cgi->param('query_format') . + ($params ? "&$params" : "")); exit; } @@ -98,7 +98,7 @@ $action ||= "assemble"; # Go to buglist.cgi if we are doing a search. if ($action eq "search") { my $params = $cgi->canonicalise_query("format", "ctype", "action"); - print "Location: buglist.cgi" . ($params ? "?$params" : "") . "\n\n"; + print $cgi->redirect("buglist.cgi" . ($params ? "?$params" : "")); exit; } -- cgit v1.2.3-24-g4f1b