From f162521444148d622df3b42a8304b6cce8f2150e Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" <> Date: Thu, 6 Jul 2006 13:12:04 +0000 Subject: Bug 173629: Clean up "my" variable scoping issues for mod_perl Patch By Max Kanat-Alexander r=LpSolit, a=myk --- chart.cgi | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'chart.cgi') diff --git a/chart.cgi b/chart.cgi index fd7025855..680eeb7b5 100755 --- a/chart.cgi +++ b/chart.cgi @@ -53,9 +53,13 @@ use Bugzilla::Chart; use Bugzilla::Series; use Bugzilla::User; -my $cgi = Bugzilla->cgi; -my $template = Bugzilla->template; -my $vars = {}; +# For most scripts we don't make $cgi and $template global variables. But +# when preparing Bugzilla for mod_perl, this script used these +# variables in so many subroutines that it was easier to just +# make them globals. +local our $cgi = Bugzilla->cgi; +local our $template = Bugzilla->template; +local our $vars = {}; # Go back to query.cgi if we are adding a boolean chart parameter. if (grep(/^cmd-/, $cgi->param())) { -- cgit v1.2.3-24-g4f1b