From f0f51946bab6b9c85c5ebd6fc737538ce967af59 Mon Sep 17 00:00:00 2001 From: Christian Ruppert Date: Thu, 10 Jul 2014 09:31:35 +0100 Subject: Bug 856598 - checksetup.pl should exit(1) if it fails checks. r=gerv, a=sgreen. --- checksetup.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'checksetup.pl') diff --git a/checksetup.pl b/checksetup.pl index c93071b88..145faf04e 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -51,14 +51,14 @@ my $answers_file = $ARGV[0]; my $silent = $answers_file && !$switch{'verbose'}; print(install_string('header', get_version_and_os()) . "\n") unless $silent; -exit if $switch{'version'}; +exit 0 if $switch{'version'}; # Check required --MODULES-- my $module_results = check_requirements(!$silent); Bugzilla::Install::Requirements::print_module_instructions( $module_results, !$silent); -exit if !$module_results->{pass}; +exit 1 if !$module_results->{pass}; # Break out if checking the modules is all we have been asked to do. -exit if $switch{'check-modules'}; +exit 0 if $switch{'check-modules'}; ########################################################################### # Load Bugzilla Modules -- cgit v1.2.3-24-g4f1b