From 20e0d1f73fdaf8954941ce65d0a976d1c620e954 Mon Sep 17 00:00:00 2001
From: "lpsolit%gmail.com" <>
Date: Tue, 19 Jul 2005 21:33:40 +0000
Subject: Bug 300709: Avoid the use of SELECT * - Patch by Frédéric Buclin
 <LpSolit@gmail.com> r=glob a=myk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 collectstats.pl | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

(limited to 'collectstats.pl')

diff --git a/collectstats.pl b/collectstats.pl
index eca072e61..a12c85586 100755
--- a/collectstats.pl
+++ b/collectstats.pl
@@ -181,11 +181,11 @@ FIN
 }
 
 sub calculate_dupes {
-    SendSQL("SELECT * FROM duplicates");
+    my $dbh = Bugzilla->dbh;
+    my $rows = $dbh->selectall_arrayref("SELECT dupe_of, dupe FROM duplicates");
 
     my %dupes;
     my %count;
-    my @row;
     my $key;
     my $changed = 1;
 
@@ -203,9 +203,8 @@ sub calculate_dupes {
 
     # Create a hash with key "a bug number", value "bug which that bug is a
     # direct dupe of" - straight from the duplicates table.
-    while (@row = FetchSQLData()) {
-        my $dupe_of = shift @row;
-        my $dupe = shift @row;
+    foreach my $row (@$rows) {
+        my ($dupe_of, $dupe) = @$row;
         $dupes{$dupe} = $dupe_of;
     }
 
-- 
cgit v1.2.3-24-g4f1b