From c64d51111a5ae02d6fc45163a847d0b7e2004548 Mon Sep 17 00:00:00 2001 From: "bugreport%peshkin.net" <> Date: Mon, 25 Nov 2002 03:56:17 +0000 Subject: Bug 147275 Rearchitect product groups Patch by joel r=bbaetz,justdave a=justdave --- describecomponents.cgi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'describecomponents.cgi') diff --git a/describecomponents.cgi b/describecomponents.cgi index b4953ddc6..a1a6f0049 100755 --- a/describecomponents.cgi +++ b/describecomponents.cgi @@ -42,11 +42,11 @@ if (!defined $::FORM{'product'}) { # Reference to a subset of %::proddesc, which the user is allowed to see my %products; - if (Param("usebuggroups")) { + if (AnyDefaultGroups()) { # OK, now only add products the user can see confirm_login() unless $::userid; foreach my $p (@::legal_product) { - if (!GroupExists($p) || UserInGroup($p)) { + if (CanEnterProduct($p)) { $products{$p} = $::proddesc{$p}; } } @@ -88,11 +88,8 @@ if (!$product_id) { } # Make sure the user is authorized to access this product. -if (Param("usebuggroups") && GroupExists($product)) { - confirm_login() unless $::userid; - UserInGroup($product) +CanEnterProduct($product) || ThrowUserError("product_access_denied"); -} ###################################################################### # End Data/Security Validation -- cgit v1.2.3-24-g4f1b