From b99cbd1d893ff0a730ab7187f409bcdf3c6f4aeb Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Wed, 16 Mar 2005 08:27:14 +0000 Subject: Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions Patch By Tomas Kopal r=joel, a=myk --- describekeywords.cgi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'describekeywords.cgi') diff --git a/describekeywords.cgi b/describekeywords.cgi index dd25c40d6..e7b3b759b 100755 --- a/describekeywords.cgi +++ b/describekeywords.cgi @@ -35,11 +35,14 @@ use vars qw($vars $template); Bugzilla->login(); my $cgi = Bugzilla->cgi; +my $dbh = Bugzilla->dbh; SendSQL("SELECT keyworddefs.name, keyworddefs.description, COUNT(keywords.bug_id) - FROM keyworddefs LEFT JOIN keywords ON keyworddefs.id=keywords.keywordid - GROUP BY keyworddefs.id + FROM keyworddefs LEFT JOIN keywords + ON keyworddefs.id = keywords.keywordid " . + $dbh->sql_group_by('keyworddefs.id', + 'keyworddefs.name, keyworddefs.description') . " ORDER BY keyworddefs.name"); my @keywords; -- cgit v1.2.3-24-g4f1b