From e18c6fd41b16c91ccb6fbca903b0716af37f27c2 Mon Sep 17 00:00:00 2001 From: "terry%mozilla.org" <> Date: Wed, 13 Oct 1999 06:00:31 +0000 Subject: Patch by Holger Schurig -- rewriting and enhancing the ability to edit components, products, and versions. Yay! --- editcomponents.cgi | 792 +++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 713 insertions(+), 79 deletions(-) (limited to 'editcomponents.cgi') diff --git a/editcomponents.cgi b/editcomponents.cgi index e4b6a23de..371c27b72 100755 --- a/editcomponents.cgi +++ b/editcomponents.cgi @@ -10,114 +10,748 @@ # basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the # License for the specific language governing rights and limitations # under the License. -# -# The Original Code is the Bugzilla Bug Tracking System. -# -# The Initial Developer of the Original Code is Netscape Communications -# Corporation. Portions created by Netscape are Copyright (C) 1998 -# Netscape Communications Corporation. All Rights Reserved. -# -# Contributor(s): Sam Ziegler -# Terry Weissman - -# Code derived from editparams.cgi, editowners.cgi +# +# +# Direct any questions on this source code to +# +# Holger Schurig use diagnostics; use strict; require "CGI.pl"; +require "globals.pl"; + +my $dobugcounts = (defined $::FORM{'dobugcounts'}); + + + +# TestProduct: just returns if the specified product does exists +# CheckProduct: same check, optionally emit an error text +# TestComponent: just returns if the specified product/component combination exists +# CheckComponent: same check, optionally emit an error text + +sub TestProduct ($) +{ + my $prod = shift; + + # does the product exist? + SendSQL("SELECT product + FROM products + WHERE product=" . SqlQuote($prod)); + return FetchOneColumn(); +} + +sub CheckProduct ($) +{ + my $prod = shift; + + # do we have a product? + unless ($prod) { + print "Sorry, you haven't specified a product."; + PutTrailer(); + exit; + } + + unless (TestProduct $prod) { + print "Sorry, product '$prod' does not exist."; + PutTrailer(); + exit; + } +} + +sub TestComponent ($$) +{ + my ($prod,$comp) = @_; + + # does the product exist? + SendSQL("SELECT program,value + FROM components + WHERE program=" . SqlQuote($prod) . " and value=" . SqlQuote($comp)); + return FetchOneColumn(); +} + +sub CheckComponent ($$) +{ + my ($prod,$comp) = @_; + + # do we have the component? + unless ($comp) { + print "Sorry, you haven't specified a component."; + PutTrailer(); + exit; + } + + CheckProduct($prod); + + unless (TestComponent $prod,$comp) { + print "Sorry, component '$comp' for product '$prod' does not exist."; + PutTrailer(); + exit; + } +} + + +# +# Displays the form to edit component parameters +# + +sub EmitFormElements ($$$$$) +{ + my ($product, $component, $initialowner, $initialqacontact, $description) = @_; + + print " Component:\n"; + print " \n"; + print " \n"; + + print "\n"; + print " Description:\n"; + print " \n"; + + print "\n"; + print " Initial owner:\n"; + print " \n"; + + if (Param('useqacontact')) { + print "\n"; + print " Initial QA contact:\n"; + print " \n"; + } +} + + +# +# Displays a text like "a.", "a or b.", "a, b or c.", "a, b, c or d." +# + +sub PutTrailer (@) +{ + my (@links) = ("Back to the query page", @_); + + my $count = $#links; + my $num = 0; + print "

\n"; + if (!$dobugcounts) { + print qq{}; + print qq{Redisplay table with bug counts (slower)

\n}; + } + foreach (@links) { + print $_; + if ($num == $count) { + print ".\n"; + } + elsif ($num == $count-1) { + print " or "; + } + else { + print ", "; + } + $num++; + } + print "\n\n"; +} + + + + -# Shut up misguided -w warnings about "used only once": -use vars @::legal_product; + +# +# Preliminary checks: +# confirm_login(); print "Content-type: text/html\n\n"; -if (!UserInGroup("editcomponents")) { - print "

Sorry, you aren't a member of the 'editcomponents' group.

\n"; - print "And so, you aren't allowed to edit the owners.\n"; +unless (UserInGroup("editcomponents")) { + PutHeader("Not allowed"); + print "Sorry, you aren't a member of the 'editcomponents' group.\n"; + print "And so, you aren't allowed to add, modify or delete components.\n"; + PutTrailer(); exit; } -PutHeader("Edit Components"); +# +# often used variables +# +my $product = trim($::FORM{product} || ''); +my $component = trim($::FORM{component} || ''); +my $action = trim($::FORM{action} || ''); +my $localtrailer; +if ($product) { + $localtrailer = "edit more components"; +} else { + $localtrailer = "edit more components"; +} + + + +# +# product = '' -> Show nice list of products +# + +unless ($product) { + PutHeader("Select product"); + + if ($dobugcounts){ + SendSQL("SELECT products.product,products.description,COUNT(bug_id) + FROM products LEFT JOIN bugs + ON products.product=bugs.product + GROUP BY products.product + ORDER BY products.product"); + } else { + SendSQL("SELECT products.product,products.description + FROM products + ORDER BY products.product"); + } + print "\n"; + print " \n"; + print " \n"; + if ($dobugcounts) { + print " \n"; + } + #print " \n"; + print ""; + while ( MoreSQLData() ) { + my ($product, $description, $bugs) = FetchSQLData(); + $description ||= "missing"; + print "\n"; + print " \n"; + print " \n"; + if ($dobugcounts) { + $bugs ||= "none"; + print " \n"; + } + #print " \n"; + } + print "
Edit components of ...DescriptionBugsEdit
$product$description$bugsEdit
\n"; -print "This lets you edit the program components of bugzilla.\n"; -print "
"; -print "Add new component.
\n"; -print "
"; + PutTrailer(); + exit; +} -print "
\n"; -my $rowbreak = "
"; -unlink "data/versioncache"; -GetVersionTable(); +# +# action='' -> Show nice list of components +# -my $prodcode = "P000"; +unless ($action) { + PutHeader("Select component"); + CheckProduct($product); -foreach my $product (@::legal_product) { - SendSQL("select description, milestoneurl, disallownew, votesperuser from products where product='$product'"); - my @row = FetchSQLData(); - if (!@row) { - next; + if ($dobugcounts) { + SendSQL("SELECT value,description,initialowner,initialqacontact,COUNT(bug_id) + FROM components LEFT JOIN bugs + ON components.program=bugs.product AND components.value=bugs.component + WHERE program=" . SqlQuote($product) . " + GROUP BY value"); + } else { + SendSQL("SELECT value,description,initialowner,initialqacontact + FROM components + WHERE program=" . SqlQuote($product) . " + GROUP BY value"); + } + print "\n"; + print " \n"; + print " \n"; + print " \n"; + print " \n" + if Param('useqacontact'); + print " \n" + if $dobugcounts; + print " \n"; + print ""; + while ( MoreSQLData() ) { + my ($component,$desc,$initialowner,$initialqacontact, $bugs) = FetchSQLData(); + $desc ||= "missing"; + $initialowner ||= "missing"; + $initialqacontact ||= "none"; + print "\n"; + print " \n"; + print " \n"; + print " \n"; + print " \n" + if Param('useqacontact'); + if ($dobugcounts) { + $bugs ||= 'none'; + print " \n"; + } + print " \n"; + print ""; } - my ($description, $milestoneurl, $disallownew, $votesperuser) = (@row); - $prodcode++; - print "\n"; - print "
Edit component ...DescriptionInitial ownerInitial QA contactBugsDelete
$component$desc$initialowner$initialqacontact$bugsDelete
\n"; - print "\n"; - print "\n"; - if (Param('usetargetmilestone')) { - print "\n"; - print "\n"; - } - print qq{\n}; - my $check0 = !$disallownew ? " SELECTED" : ""; - my $check1 = $disallownew ? " SELECTED" : ""; - print "\n"; - - print "
$product
Description:
MilestoneURL:
Maximum votes per user:\n}; - print qq{}; - print qq{
Components:
\n"; - print "\n"; + print "\n"; + my $span = 3; + $span++ if Param('useqacontact'); + $span++ if $dobugcounts; + print " \n"; + print " \n"; + print "
Add a new componentAdd
\n"; + + PutTrailer(); + exit; +} + + +$dobugcounts = 1; # Stupid hack to force further PutTrailer() + # calls to not offer a "bug count" option. + + +# +# action='add' -> present form for parameters for new component +# +# (next action will be 'new') +# + +if ($action eq 'add') { + PutHeader("Add component"); + CheckProduct($product); + + #print "This page lets you add a new product to bugzilla.\n"; + + print "\n"; + print "\n"; + + EmitFormElements($product, '', '', '', ''); + + print "
\n
\n"; + print "\n"; + print "\n"; + print "
"; + + my $other = $localtrailer; + $other =~ s/more/other/; + PutTrailer($other); + exit; +} + + + +# +# action='new' -> add component entered in the 'action=add' screen +# + +if ($action eq 'new') { + PutHeader("Adding new product"); + CheckProduct($product); + + # Cleanups and valididy checks + + unless ($component) { + print "You must enter a name for the new component. Please press\n"; + print "Back and try again.\n"; + PutTrailer($localtrailer); + exit; + } + if (TestComponent($product,$component)) { + print "The component '$component' already exists. Please press\n"; + print "Back and try again.\n"; + PutTrailer($localtrailer); + exit; + } + + my $description = trim($::FORM{description} || ''); + + if ($description eq '') { + print "You must enter a description for the component '$component'. Please press\n"; + print "Back and try again.\n"; + PutTrailer($localtrailer); + exit; + } + + my $initialowner = trim($::FORM{initialowner} || ''); + + if ($initialowner eq '') { + print "You must enter an initial owner for the component '$component'. Please press\n"; + print "Back and try again.\n"; + PutTrailer($localtrailer); + exit; + } + #+++ + #DBNameToIdAndCheck($initialowner, 0); + + my $initialqacontact = trim($::FORM{initialqacontact} || ''); + + if (Param('useqacontact')) { + if ($initialqacontact eq '') { + print "You must enter an initial QA contact for the component '$component'. Please press\n"; + print "Back and try again.\n"; + PutTrailer($localtrailer); + exit; + } + #+++ + #DBNameToIdAndCheck($initialqacontact, 0); + } + + # Add the new component + SendSQL("INSERT INTO components ( " . + "program, value, description, initialowner, initialqacontact " . + " ) VALUES ( " . + SqlQuote($product) . "," . + SqlQuote($component) . "," . + SqlQuote($description) . "," . + SqlQuote($initialowner) . "," . + SqlQuote($initialqacontact) . ")"); + + # Make versioncache flush + unlink "data/versioncache"; + + print "OK, done.

\n"; + PutTrailer($localtrailer); + exit; +} + + + +# +# action='del' -> ask if user really wants to delete +# +# (next action would be 'delete') +# + +if ($action eq 'del') { + PutHeader("Delete component"); + CheckComponent($product, $component); + + # display some data about the component + SendSQL("SELECT products.product,products.description, + products.milestoneurl,products.disallownew, + components.program,components.value,components.initialowner, + components.initialqacontact,components.description + FROM products + LEFT JOIN components on product=program + WHERE product=" . SqlQuote($product) . " + AND value=" . SqlQuote($component) ); + + + my ($product,$pdesc,$milestoneurl,$disallownew, + $dummy,$component,$initialowner,$initialqacontact,$cdesc) = FetchSQLData(); + + $pdesc ||= "missing"; + $milestoneurl ||= "missing"; + $disallownew = $disallownew ? 'closed' : 'open'; + $initialowner ||= "missing"; + $initialqacontact ||= "missing"; + $cdesc ||= "missing"; - SendSQL("select value, initialowner, initialqacontact, description from components where program=" . SqlQuote($product) . " order by value"); - my $c = 0; - while (my @row = FetchSQLData()) { - my ($component, $initialowner, $initialqacontact, $description) = - (@row); - $c++; - my $compcode = $prodcode . "-" . "C$c"; - print "\n"; - print "$componentDescription:\n"; - print "\n"; - print "Initial owner:\n"; - print "\n"; - if (Param('useqacontact')) { - print "Initial QA contact:\n"; - print "\n"; + print "\n"; + print " \n"; + print " \n"; + + print "\n"; + print " \n"; + print " "; + + print "\n"; + print " \n"; + print " "; + + print "\n"; + print " \n"; + print " "; + + if (Param('useqacontact')) { + print "\n"; + print " \n"; + print " "; + } + SendSQL("SELECT count(bug_id),product,component + FROM bugs + GROUP BY product + HAVING product=" . SqlQuote($product) . " + AND component=" . SqlQuote($component)); + + print "\n"; + print " \n"; + print " \n"; + + print "\n"; + print " \n"; + print " \n"; + + if (Param('usetargetmilestone')) { + print "\n"; + print " \n"; + print " \n"; + } + + print "\n"; + print " \n"; + print " \n"; + + print "\n"; + print " \n"; + print " \n
PartValue
Component:$component
Component description:$cdesc
Initial owner:$initialowner
Initial QA contact:$initialqacontact
Component of product:$product
Description:$pdesc
Milestone URL:$milestoneurl
Closed for bugs:$disallownew
Bugs"; + my $bugs = FetchOneColumn(); + print $bugs || 'none'; + + + print "
"; + + print "

Confirmation

\n"; + + if ($bugs) { + if (!Param("allowbugdeletion")) { + print "Sorry, there are $bugs bugs outstanding for this component. +You must reassign those bugs to another component before you can delete this +one."; + PutTrailer($localtrailer); + exit; + } + print "
\n", + "There are bugs entered for this component! When you delete this ", + "component, all stored bugs will be deleted, too. ", + "You could not even see the bug history for this component anymore!\n", + "
\n"; + } + + print "

Do you really want to delete this component?

\n"; + + print "

\n"; + print "\n"; + print "\n"; + print "\n"; + print "\n"; + print "
"; + + PutTrailer($localtrailer); + exit; +} + + + +# +# action='delete' -> really delete the component +# + +if ($action eq 'delete') { + PutHeader("Deleting component"); + CheckComponent($product,$component); + + # lock the tables before we start to change everything: + + SendSQL("LOCK TABLES attachments WRITE, + bugs WRITE, + bugs_activity WRITE, + components WRITE, + dependencies WRITE"); + + # According to MySQL doc I cannot do a DELETE x.* FROM x JOIN Y, + # so I have to iterate over bugs and delete all the indivial entries + # in bugs_activies and attachments. + + SendSQL("SELECT bug_id + FROM bugs + WHERE product=" . SqlQuote($product) . " + AND component=" . SqlQuote($component)); + while (MoreSQLData()) { + my $bugid = FetchOneColumn(); + + my $query = $::db->query("DELETE FROM attachments WHERE bug_id=$bugid") + or die "$::db_errstr"; + $query = $::db->query("DELETE FROM bugs_activity WHERE bug_id=$bugid") + or die "$::db_errstr"; + $query = $::db->query("DELETE FROM dependencies WHERE blocked=$bugid") + or die "$::db_errstr"; + } + print "Attachments, bug activity and dependencies deleted.
\n"; + + + # Deleting the rest is easier: + + SendSQL("DELETE FROM bugs + WHERE product=" . SqlQuote($product) . " + AND component=" . SqlQuote($component)); + print "Bugs deleted.
\n"; + + SendSQL("DELETE FROM components + WHERE program=" . SqlQuote($product) . " + AND value=" . SqlQuote($component)); + print "Components deleted.

\n"; + SendSQL("UNLOCK TABLES"); + + unlink "data/versioncache"; + PutTrailer($localtrailer); + exit; +} + + + +# +# action='edit' -> present the edit component form +# +# (next action would be 'update') +# + +if ($action eq 'edit') { + PutHeader("Edit component"); + CheckComponent($product,$component); + + # get data of component + SendSQL("SELECT products.product,products.description, + products.milestoneurl,products.disallownew, + components.program,components.value,components.initialowner, + components.initialqacontact,components.description + FROM products + LEFT JOIN components on product=program + WHERE product=" . SqlQuote($product) . " + AND value=" . SqlQuote($component) ); + + my ($product,$pdesc,$milestoneurl,$disallownew, + $dummy,$component,$initialowner,$initialqacontact,$cdesc) = FetchSQLData(); + + print "

\n"; + print "\n"; + + #+++ display product/product description + + EmitFormElements($product, $component, $initialowner, $initialqacontact, $cdesc); + + print "\n"; + print " \n"; + print " \n
Bugs:"; + SendSQL("SELECT count(*) + FROM bugs + WHERE product=" . SqlQuote($product) . + " and component=" . SqlQuote($component)); + my $bugs = ''; + $bugs = FetchOneColumn() if MoreSQLData(); + print $bugs || 'none'; + + print "
\n"; + + print "\n"; + print "\n"; + print "\n"; + print "\n"; + print "\n"; + print "\n"; + + print "
"; + + my $other = $localtrailer; + $other =~ s/more/other/; + PutTrailer($other); + exit; +} + + + +# +# action='update' -> update the component +# + +if ($action eq 'update') { + PutHeader("Update component"); + + my $componentold = trim($::FORM{componentold} || ''); + my $description = trim($::FORM{description} || ''); + my $descriptionold = trim($::FORM{descriptionold} || ''); + my $initialowner = trim($::FORM{initialowner} || ''); + my $initialownerold = trim($::FORM{initialownerold} || ''); + my $initialqacontact = trim($::FORM{initialqacontact} || ''); + my $initialqacontactold = trim($::FORM{initialqacontactold} || ''); + + CheckComponent($product,$componentold); + + # Note that the order of this tests is important. If you change + # them, be sure to test for WHERE='$component' or WHERE='$componentold' + + SendSQL("LOCK TABLES bugs WRITE, + components WRITE"); + + if ($description ne $descriptionold) { + unless ($description) { + print "Sorry, I can't delete the description."; + PutTrailer($localtrailer); + SendSQL("UNLOCK TABLES"); + exit; + } + SendSQL("UPDATE components + SET description=" . SqlQuote($description) . " + WHERE program=" . SqlQuote($product) . " + AND value=" . SqlQuote($componentold)); + print "Updated description.
\n"; + } + + + if ($initialowner ne $initialownerold) { + unless ($initialowner) { + print "Sorry, I can't delete the initial owner."; + PutTrailer($localtrailer); + SendSQL("UNLOCK TABLES"); + exit; + } + #+++ + #DBNameToIdAndCheck($initialowner, 0); + SendSQL("UPDATE components + SET initialowner=" . SqlQuote($initialowner) . " + WHERE program=" . SqlQuote($product) . " + AND value=" . SqlQuote($componentold)); + print "Updated initial owner.
\n"; + } + + if (Param('useqacontact') && $initialqacontact ne $initialqacontactold) { + unless ($initialqacontact) { + print "Sorry, I can't delete the initial QA contact."; + PutTrailer($localtrailer); + SendSQL("UNLOCK TABLES"); + exit; } + #+++ + #DBNameToIdAndCheck($initialqacontact, 0); + SendSQL("UPDATE components + SET initialqacontact=" . SqlQuote($initialqacontact) . " + WHERE program=" . SqlQuote($product) . " + AND value=" . SqlQuote($componentold)); + print "Updated initial QA contact.
\n"; } - print "
\n"; + if ($component ne $componentold) { + unless ($component) { + print "Sorry, I can't delete the product name."; + PutTrailer($localtrailer); + SendSQL("UNLOCK TABLES"); + exit; + } + if (TestComponent($product,$component)) { + print "Sorry, component name '$component' is already in use."; + PutTrailer($localtrailer); + SendSQL("UNLOCK TABLES"); + exit; + } + + SendSQL("UPDATE bugs + SET component=" . SqlQuote($component) . " + WHERE component=" . SqlQuote($componentold) . " + AND product=" . SqlQuote($product)); + SendSQL("UPDATE components + SET value=" . SqlQuote($component) . " + WHERE value=" . SqlQuote($componentold) . " + AND program=" . SqlQuote($product)); + + unlink "data/versioncache"; + print "Updated product name.
\n"; + } + SendSQL("UNLOCK TABLES"); + + PutTrailer($localtrailer); + exit; } -print "\n"; -print "\n"; -print "

Skip all this, and go back to the query page\n"; +# +# No valid action found +# + +PutHeader("Error"); +print "I don't have a clue what you want.
\n"; + +foreach ( sort keys %::FORM) { + print "$_: $::FORM{$_}
\n"; +} -- cgit v1.2.3-24-g4f1b