From fba06c0a5f82ddf2f73ef068752d697666464dc1 Mon Sep 17 00:00:00 2001 From: "bugreport%peshkin.net" <> Date: Tue, 27 Jul 2004 22:13:48 +0000 Subject: Bug 252450: Unlock tables in edit*.cgi before sending trailer r=kiko a=justdave --- editcomponents.cgi | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'editcomponents.cgi') diff --git a/editcomponents.cgi b/editcomponents.cgi index 00c06912f..864986d80 100755 --- a/editcomponents.cgi +++ b/editcomponents.cgi @@ -162,6 +162,7 @@ sub EmitFormElements ($$$$$) sub PutTrailer (@) { my (@links) = ("Back to the query page", @_); + SendSQL("UNLOCK TABLES"); my $count = $#links; my $num = 0; @@ -675,7 +676,6 @@ if ($action eq 'delete') { SendSQL("DELETE FROM components WHERE id=$component_id"); print "Components deleted.
\n";
- SendSQL("UNLOCK TABLES");
unlink "$datadir/versioncache";
PutTrailer($localtrailer);
@@ -782,7 +782,6 @@ if ($action eq 'update') {
unless ($description) {
print "Sorry, I can't delete the description.";
PutTrailer($localtrailer);
- SendSQL("UNLOCK TABLES");
exit;
}
SendSQL("UPDATE components
@@ -795,7 +794,6 @@ if ($action eq 'update') {
if ($initialowner ne $initialownerold) {
unless ($initialowner) {
print "Sorry, I can't delete the initial owner.";
- SendSQL("UNLOCK TABLES");
PutTrailer($localtrailer);
exit;
}
@@ -803,7 +801,6 @@ if ($action eq 'update') {
my $initialownerid = DBname_to_id($initialowner);
unless ($initialownerid) {
print "Sorry, you must use an existing Bugzilla account as initial owner.";
- SendSQL("UNLOCK TABLES");
PutTrailer($localtrailer);
exit;
}
@@ -818,7 +815,6 @@ if ($action eq 'update') {
my $initialqacontactid = DBname_to_id($initialqacontact);
if (!$initialqacontactid && $initialqacontact ne '') {
print "Sorry, you must use an existing Bugzilla account as initial QA contact.";
- SendSQL("UNLOCK TABLES");
PutTrailer($localtrailer);
exit;
}
@@ -834,13 +830,11 @@ if ($action eq 'update') {
unless ($component) {
print "Sorry, but a component must have a name.";
PutTrailer($localtrailer);
- SendSQL("UNLOCK TABLES");
exit;
}
if (TestComponent($product,$component)) {
print "Sorry, component name '$component' is already in use.";
PutTrailer($localtrailer);
- SendSQL("UNLOCK TABLES");
exit;
}
@@ -850,7 +844,6 @@ if ($action eq 'update') {
unlink "$datadir/versioncache";
print "Updated component name.
\n";
}
- SendSQL("UNLOCK TABLES");
PutTrailer($localtrailer);
exit;
--
cgit v1.2.3-24-g4f1b