From 0e70cd46fe9377b9a267a8e1efbc6f8e7064e95e Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Sun, 20 Aug 2006 06:02:55 +0000 Subject: Bug 344875: Implement a UI to manage custom fields and remove customfield.pl - Patch by Frédéric Buclin r=mkanat a=myk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- editfields.cgi | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100644 editfields.cgi (limited to 'editfields.cgi') diff --git a/editfields.cgi b/editfields.cgi new file mode 100644 index 000000000..17db14092 --- /dev/null +++ b/editfields.cgi @@ -0,0 +1,120 @@ +#!/usr/bin/perl -wT +# -*- Mode: perl; indent-tabs-mode: nil -*- +# +# The contents of this file are subject to the Mozilla Public +# License Version 1.1 (the "License"); you may not use this file +# except in compliance with the License. You may obtain a copy of +# the License at http://www.mozilla.org/MPL/ +# +# Software distributed under the License is distributed on an "AS +# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or +# implied. See the License for the specific language governing +# rights and limitations under the License. +# +# The Original Code is the Bugzilla Bug Tracking System. +# +# Contributor(s): Frédéric Buclin + +use strict; +use lib "."; + +use Bugzilla; +use Bugzilla::Constants; +use Bugzilla::Error; +use Bugzilla::Util; +use Bugzilla::Field; + +my $cgi = Bugzilla->cgi; +my $template = Bugzilla->template; +my $vars = {}; + +# Make sure the user is logged in and is an administrator. +my $user = Bugzilla->login(LOGIN_REQUIRED); +$user->in_group('admin') + || ThrowUserError('auth_failure', {group => 'admin', + action => 'edit', + object => 'custom_fields'}); + +my $action = trim($cgi->param('action') || ''); + +print $cgi->header(); + +# List all existing custom fields if no action is given. +if (!$action) { + $vars->{'custom_fields'} = [Bugzilla->get_fields({'custom' => 1})]; + + $template->process('admin/custom_fields/list.html.tmpl', $vars) + || ThrowTemplateError($template->error()); +} +# Interface to add a new custom field. +elsif ($action eq 'add') { + $template->process('admin/custom_fields/create.html.tmpl') + || ThrowTemplateError($template->error()); +} +elsif ($action eq 'new') { + my $name = clean_text($cgi->param('name') || ''); + my $desc = clean_text($cgi->param('desc') || ''); + # For now, there is only one type available for custom fields. + # In the future, we will have to look at $cgi->param('type'). + my $type = FIELD_TYPE_FREETEXT; + my $sortkey = $cgi->param('sortkey') || 0; + + # Validate these fields. + $name || ThrowUserError('customfield_missing_name'); + # Prepend cf_ to the custom field name to distinguish it from standard fields. + if ($name !~ /^cf_/) { + $name = 'cf_' . $name; + } + my $field = new Bugzilla::Field({'name' => $name}); + ThrowUserError('customfield_already_exists', {'field' => $field }) if $field; + + $desc || ThrowUserError('customfield_missing_description', {'name' => $name}); + + my $skey = $sortkey; + detaint_natural($sortkey) + || ThrowUserError('customfield_invalid_sortkey', {'name' => $name, + 'sortkey' => $skey}); + + # All fields have been validated. We can create this new custom field. + trick_taint($name); + trick_taint($desc); + + $vars->{'name'} = $name; + $vars->{'desc'} = $desc; + $vars->{'sortkey'} = $sortkey; + $vars->{'type'} = $type; + $vars->{'custom'} = 1; + $vars->{'in_new_bugmail'} = $cgi->param('new_bugmail') ? 1 : 0; + $vars->{'editable_on_enter_bug'} = $cgi->param('enter_bug') ? 1 : 0; + $vars->{'is_obsolete'} = $cgi->param('obsolete') ? 1 : 0; + + Bugzilla::Field::create_or_update($vars); + + $vars->{'custom_fields'} = [Bugzilla->get_fields({'custom' => 1})]; + + $template->process('admin/custom_fields/list.html.tmpl', $vars) + || ThrowTemplateError($template->error()); +} +elsif ($action eq 'edit') { + my $name = $cgi->param('name') || ThrowUserError('customfield_missing_name'); + trick_taint($name); + my @field = Bugzilla->get_fields({'name' => $name, 'custom' => 1}); + scalar(@field) || ThrowUserError('customfield_nonexistent', {'name' => $name}); + + $vars->{'field'} = $field[0]; + + $template->process('admin/custom_fields/edit.html.tmpl', $vars) + || ThrowTemplateError($template->error()); +} +elsif ($action eq 'update') { + die "not yet implemented...\n"; +} +elsif ($action eq 'del') { + die "not yet implemented...\n"; +} +elsif ($action eq 'delete') { + die "not yet implemented...\n"; +} +else { + ThrowUserError('no_valid_action', {'field' => 'custom_field'}); +} -- cgit v1.2.3-24-g4f1b