From 70486766bd51504b7e96a8a3cf726f31d3a77f78 Mon Sep 17 00:00:00 2001
From: "travis%sedsystems.ca" <>
Date: Wed, 2 Mar 2005 02:34:25 +0000
Subject: Bug 238802 : Input filter for integer sort key gives bad error output
 Patch by Frederic Buclin <LpSolit@gmail.com>  r=mkanat  a=justdave

---
 editflagtypes.cgi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'editflagtypes.cgi')

diff --git a/editflagtypes.cgi b/editflagtypes.cgi
index c28fda4ba..9c14219d2 100755
--- a/editflagtypes.cgi
+++ b/editflagtypes.cgi
@@ -445,8 +445,10 @@ sub deactivate {
 ################################################################################
 
 sub validateID {
+    # $::FORM{'id'} is destroyed if detaint_natural fails.
+    my $flagtype_id = $::FORM{'id'};
     detaint_natural($::FORM{'id'})
-      || ThrowCodeError("flag_type_id_invalid", { id => $::FORM{'id'} });
+      || ThrowCodeError("flag_type_id_invalid", { id => $flagtype_id });
 
     SendSQL("SELECT 1 FROM flagtypes WHERE id = $::FORM{'id'}");
     FetchOneColumn()
@@ -499,10 +501,12 @@ sub validateComponent {
 }
 
 sub validateSortKey {
+    # $::FORM{'sortkey'} is destroyed if detaint_natural fails.
+    my $sortkey = $::FORM{'sortkey'};
     detaint_natural($::FORM{'sortkey'})
       && $::FORM{'sortkey'} < 32768
       || ThrowUserError("flag_type_sortkey_invalid", 
-                        { sortkey => $::FORM{'sortkey'} });
+                        { sortkey => $sortkey });
 }
 
 sub validateTargetType {
-- 
cgit v1.2.3-24-g4f1b