From f5f31fc070588c2075dd13a0fbabe8117e3aad76 Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Tue, 5 Apr 2005 04:52:03 +0000 Subject: Bug 286235: Implicit joins should be replaced by explicit joins - installment A Patch By Tomas Kopal r=joel, a=myk --- editmilestones.cgi | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'editmilestones.cgi') diff --git a/editmilestones.cgi b/editmilestones.cgi index 0edbd1897..796643e9e 100755 --- a/editmilestones.cgi +++ b/editmilestones.cgi @@ -79,9 +79,10 @@ sub TestMilestone ($$) # does the product exist? my $sth = $dbh->prepare_cached(" SELECT products.name, value - FROM milestones, products - WHERE milestones.product_id = products.id - AND products.name = ? + FROM milestones + INNER JOIN products + ON milestones.product_id = products.id + WHERE products.name = ? AND value = ?"); trick_taint($product); -- cgit v1.2.3-24-g4f1b