From 68774da9a61107cfbbc16a91421a99c1ac944df1 Mon Sep 17 00:00:00 2001
From: "justdave%syndicomm.com" <>
Date: Sun, 26 Oct 2003 10:37:48 +0000
Subject: Bug 208647: Fixes taint error in add new products code. Patch by
 jpyeron@pyerotechnics.com (Jason Pyeron) r= bbaetz, a= justdave

---
 editproducts.cgi | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

(limited to 'editproducts.cgi')

diff --git a/editproducts.cgi b/editproducts.cgi
index 1782a74b8..c36537c22 100755
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -337,8 +337,15 @@ if ($action eq 'new') {
             SqlQuote($product) . "," .
             SqlQuote($description) . "," .
             SqlQuote($milestoneurl) . "," .
-            $disallownew . "," .
-            "$votesperuser, $maxvotesperbug, $votestoconfirm, " .
+            # had tainting issues under cygwin, IIS 5.0, perl -T %s %s
+            # see bug 208647. http://bugzilla.mozilla.org/show_bug.cgi?id=208647
+            # had to de-taint $disallownew, $votesperuser, $maxvotesperbug,
+            #  and $votestoconfirm w/ SqlQuote()
+            # - jpyeron@pyerotechnics.com
+            SqlQuote($disallownew) . "," .
+            SqlQuote($votesperuser) . "," .
+            SqlQuote($maxvotesperbug) . "," .
+            SqlQuote($votestoconfirm) . "," .
             SqlQuote($defaultmilestone) . ")");
     SendSQL("SELECT LAST_INSERT_ID()");
     my $product_id = FetchOneColumn();
-- 
cgit v1.2.3-24-g4f1b