From dddc17ec8b38d7f90b7be7d9fd6ab9629077f3df Mon Sep 17 00:00:00 2001 From: "mkanat%kerio.com" <> Date: Sat, 13 Aug 2005 19:27:03 +0000 Subject: Bug 303669: Bugzilla mis-uses perl subroutine prototypes Patch By Max Kanat-Alexander r=LpSolit, a=justdave --- editproducts.cgi | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'editproducts.cgi') diff --git a/editproducts.cgi b/editproducts.cgi index cacf8eef8..d6d909360 100755 --- a/editproducts.cgi +++ b/editproducts.cgi @@ -53,7 +53,7 @@ my %ctl = ( # TestProduct: just returns if the specified product does exists # CheckProduct: same check, optionally emit an error text -sub TestProduct ($) +sub TestProduct { my $prod = shift; @@ -64,7 +64,7 @@ sub TestProduct ($) return FetchOneColumn(); } -sub CheckProduct ($) +sub CheckProduct { my $prod = shift; @@ -85,7 +85,7 @@ sub CheckProduct ($) # TestClassification: just returns if the specified classification does exists # CheckClassification: same check, optionally emit an error text -sub TestClassification ($) +sub TestClassification { my $cl = shift; @@ -96,7 +96,7 @@ sub TestClassification ($) return FetchOneColumn(); } -sub CheckClassification ($) +sub CheckClassification { my $cl = shift; @@ -118,7 +118,7 @@ sub CheckClassification ($) # we need this routine, which does things properly, and will # eventually be the only version. (The older versions assume a # $template->put_header() call has been made) -sub CheckClassificationNew ($) +sub CheckClassificationNew { my $cl = shift; @@ -134,7 +134,7 @@ sub CheckClassificationNew ($) } -sub CheckClassificationProduct ($$) +sub CheckClassificationProduct { my $cl = shift; my $prod = shift; @@ -161,7 +161,7 @@ sub CheckClassificationProduct ($$) } } -sub CheckClassificationProductNew ($$) +sub CheckClassificationProductNew { my ($cl, $prod) = @_; my $dbh = Bugzilla->dbh; @@ -189,7 +189,7 @@ sub CheckClassificationProductNew ($$) # Displays the form to edit a products parameters # -sub EmitFormElements ($$$$$$$$$) +sub EmitFormElements { my ($classification, $product, $description, $milestoneurl, $disallownew, $votesperuser, $maxvotesperbug, $votestoconfirm, $defaultmilestone) @@ -250,7 +250,7 @@ sub EmitFormElements ($$$$$$$$$) # Displays a text like "a.", "a or b.", "a, b or c.", "a, b, c or d." # -sub PutTrailer (@) +sub PutTrailer { my (@links) = ("Back to the query page", @_); -- cgit v1.2.3-24-g4f1b