From 0066e681a05fb471d9468119e755a00e40dd19f5 Mon Sep 17 00:00:00 2001 From: "bugreport%peshkin.net" <> Date: Sat, 10 Jul 2004 14:39:56 +0000 Subject: Bug 233486: Only process groups user is supposed to be able to bless in editgroups.cgi r=justdave a=justdave --- editusers.cgi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'editusers.cgi') diff --git a/editusers.cgi b/editusers.cgi index 9dfc672d9..ed8f974e2 100755 --- a/editusers.cgi +++ b/editusers.cgi @@ -155,7 +155,7 @@ sub EmitFormElements ($$$$) print "User is a member of these groups\n"; while (MoreSQLData()) { my ($groupid, $name, $description, $checked, $isderived, $isregexp) = FetchSQLData(); - next if (!$editall && !UserCanBlessGroup($name)); + next unless ($editall || UserCanBlessGroup($name)); PushGlobalSQLState(); SendSQL("SELECT user_id " . "FROM user_group_map " . @@ -762,6 +762,7 @@ if ($action eq 'update') { my $chggrp = 0; SendSQL("SELECT id, name FROM groups"); while (my ($groupid, $name) = FetchSQLData()) { + next unless ($editall || UserCanBlessGroup($name)); if ($::FORM{"oldgroup_$groupid"} != ($::FORM{"group_$groupid"} ? 1 : 0)) { # group membership changed PushGlobalSQLState(); -- cgit v1.2.3-24-g4f1b