From b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Wed, 28 Jan 2009 23:27:27 +0000 Subject: Bug 471523: Cloning a bug copies the newest visible comment for Newest to Oldest comment order - Patch by Frédéric Buclin r=mkanat a=LpSolit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- enter_bug.cgi | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'enter_bug.cgi') diff --git a/enter_bug.cgi b/enter_bug.cgi index d463a7a11..ef0314bca 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -422,14 +422,17 @@ if ($cloned_bug_id) { # We need to ensure that we respect the 'insider' status of # the first comment, if it has one. Either way, make a note # that this bug was cloned from another bug. - - my $isprivate = $cloned_bug->longdescs->[0]->{'isprivate'}; + # We cannot use $cloned_bug->longdescs because this method + # depends on the "comment_sort_order" user pref, and we + # really want the first comment of the bug. + my $bug_desc = Bugzilla::Bug::GetComments($cloned_bug_id, 'oldest_to_newest'); + my $isprivate = $bug_desc->[0]->{'isprivate'}; $vars->{'comment'} = ""; $vars->{'commentprivacy'} = 0; - if ( !($isprivate) || Bugzilla->user->is_insider ) { - $vars->{'comment'} = $cloned_bug->longdescs->[0]->{'body'}; + if (!$isprivate || Bugzilla->user->is_insider) { + $vars->{'comment'} = $bug_desc->[0]->{'body'}; $vars->{'commentprivacy'} = $isprivate; } -- cgit v1.2.3-24-g4f1b