From 84b390d25f1427f7f10265f70e19157689c924c5 Mon Sep 17 00:00:00 2001 From: Ed Morley Date: Mon, 29 Sep 2014 17:32:12 -0400 Subject: Bug 1072981 - User activity labels & params conflate "sort" and "group" --- extensions/BMO/lib/Reports/UserActivity.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'extensions/BMO/lib/Reports') diff --git a/extensions/BMO/lib/Reports/UserActivity.pm b/extensions/BMO/lib/Reports/UserActivity.pm index 77ba10b95..04810c2ec 100644 --- a/extensions/BMO/lib/Reports/UserActivity.pm +++ b/extensions/BMO/lib/Reports/UserActivity.pm @@ -100,7 +100,7 @@ sub report { push @params, ($from_dt, $to_dt); } - my $order = ($input->{'sort'} && $input->{'sort'} eq 'bug') + my $order = ($input->{'group'} && $input->{'group'} eq 'bug') ? 'bug_id, bug_when' : 'bug_when'; my $comment_filter = ''; @@ -257,7 +257,7 @@ sub report { $incomplete_data = 1; } - # Start a new changeset if required (depends on the sort order) + # Start a new changeset if required (depends on the grouping type) my $is_new_changeset; if ($order eq 'bug_when') { $is_new_changeset = @@ -321,7 +321,7 @@ sub report { $vars->{'who_count'} = scalar @who; $vars->{'from'} = $from; $vars->{'to'} = $to; - $vars->{'sort'} = $input->{'sort'}; + $vars->{'group'} = $input->{'group'}; } 1; -- cgit v1.2.3-24-g4f1b